1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-15 09:01:12 +01:00

Fix for Bug 697 Incorrect naming of Compressor 'release phase'

http://bugzilla.audacityteam.org/show_bug.cgi?id=697
Patch by Steve Daulton alters the UI strings but leaves variable naming alone. Provides backwards compatibility with old chains via a string substitution - to come out in time.
This commit is contained in:
RichardAsh1981@gmail.com
2013-12-23 10:31:47 +00:00
parent b967013fdf
commit 0b2e58dde9
3 changed files with 11 additions and 6 deletions

View File

@@ -102,7 +102,7 @@ bool EffectCompressor::TransferParameters( Shuttle & shuttle )
shuttle.TransferDouble( wxT("NoiseFloor"), mNoiseFloorDB, -40.0f );
shuttle.TransferDouble( wxT("Ratio"), mRatio, 2.0f );
shuttle.TransferDouble( wxT("AttackTime"), mAttackTime, 0.2f );
shuttle.TransferDouble( wxT("DecayTime"), mDecayTime, 1.0f );
shuttle.TransferDouble( wxT("ReleaseTime"), mDecayTime, 1.0f );
shuttle.TransferBool( wxT("Normalize"), mNormalize, true );
shuttle.TransferBool( wxT("UsePeak"), mUsePeak, false );
return true;
@@ -658,11 +658,11 @@ void CompressorDialog::PopulateOrExchange(ShuttleGui & S)
mAttackText = S.AddVariableText(wxT("XXXX secs"), true,
wxALIGN_LEFT | wxALIGN_CENTER_VERTICAL);
mDecayLabel = S.AddVariableText(_("Decay Time:"), true,
mDecayLabel = S.AddVariableText(_("Release Time:"), true,
wxALIGN_RIGHT | wxALIGN_CENTER_VERTICAL);
S.SetStyle(wxSL_HORIZONTAL);
mDecaySlider = S.Id(DecayID).AddSlider(wxT(""), 2, 30, 1);
mDecaySlider->SetName(_("Decay Time"));
mDecaySlider->SetName(_("Release Time"));
mDecayText = S.AddVariableText(wxT("XXXX secs"), true,
wxALIGN_LEFT | wxALIGN_CENTER_VERTICAL);
}
@@ -741,7 +741,7 @@ bool CompressorDialog::TransferDataFromWindow()
mAttackText->SetLabel(wxString::Format(_("%.1f secs"), attack));
mAttackText->SetName(mAttackText->GetLabel()); // fix for bug 577 (NVDA/Narrator screen readers do not read static text in dialogs)
mDecayLabel->SetName(wxString::Format(_("Decay Time %.1f secs"), decay));
mDecayLabel->SetName(wxString::Format(_("Release Time %.1f secs"), decay));
mDecayText->SetLabel(wxString::Format(_("%.1f secs"), decay));
mDecayText->SetName(mDecayText->GetLabel()); // fix for bug 577 (NVDA/Narrator screen readers do not read static text in dialogs)