Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-01 15:43:44 +02:00
Code Issues Releases Wiki Activity

Amend r11458 - only do the .mp3 extension diversion for linux, where the alternate versions of libsndfile can exist

Browse Source
This commit is contained in:
mchinen 2012-02-05 09:26:09 +00:00
parent 087c7d10d7
commit 07e3469c9e
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/import/ImportPCM.cpp
View File

@ -127,9 +127,13 @@ ImportFileHandle *PCMImportPlugin::Open(wxString filename)
wxFile f; // will be closed when it goes out of scope
#ifdef __WXGTK__
if (filename.Lower().EndsWith(wxT("mp3"))) {
// There is a bug in libsndfile where mp3s with duplicated metadata tags
// will crash libsndfile and thus audacity.
// We have patched the lib-src version of libsndfile, but
// for linux the user can build against the system libsndfile which
// still has this bug.
// This happens in sf_open_fd, which is the very first point of
// interaction with libsndfile, so the only workaround is to hardcode
// ImportPCM to not handle .mp3. Of couse, this will still fail for mp3s
@ -137,6 +141,7 @@ ImportFileHandle *PCMImportPlugin::Open(wxString filename)
// So, in the future we may want to write a simple parser to detect mp3s here.
return NULL;
}
#endif
if (f.Open(filename)) {