From 9cfcfcb5bea88ba464acba681541a8b3ecbf89f6 Mon Sep 17 00:00:00 2001 From: Fred Gleason Date: Mon, 3 Apr 2017 11:04:39 -0400 Subject: [PATCH] 2017-04-03 Fred Gleason * Changed all instances of authorization failure in the rdxport service to return code 404. --- ChangeLog | 3 +++ web/rdxport/carts.cpp | 14 +++++++------- web/rdxport/deleteaudio.cpp | 2 +- web/rdxport/import.cpp | 4 ++-- 4 files changed, 13 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index 8d727c7b..f26f1387 100644 --- a/ChangeLog +++ b/ChangeLog @@ -15693,3 +15693,6 @@ * Changed the '401' result code of the 'EditCart' service to be 403. * Changed the '401' result code of the 'DeleteAudio' service to be 403. * Changed the '401' result code of the 'Export' service to be 403. +2017-04-03 Fred Gleason + * Changed all instances of authorization failure in the rdxport service + to return code 404. diff --git a/web/rdxport/carts.cpp b/web/rdxport/carts.cpp index 2f20b80f..d11393cc 100644 --- a/web/rdxport/carts.cpp +++ b/web/rdxport/carts.cpp @@ -81,11 +81,11 @@ void Xport::AddCart() } if(!group->cartNumberValid(cart_number)) { delete group; - XmlExit("Cart number out of range for group",403); + XmlExit("Cart number out of range for group",404); } delete group; if(!xport_user->createCarts()) { - XmlExit("Forbidden",403); + XmlExit("Forbidden",404); } // @@ -249,7 +249,7 @@ void Xport::EditCart() XmlExit("No such cart",404); } if(!xport_user->modifyCarts()) { - XmlExit("Unauthorized",403); + XmlExit("Unauthorized",404); } if(xport_post->getValue("GROUP_NAME",&group_name)) { if(!xport_user->groupAuthorized(group_name)) { @@ -413,7 +413,7 @@ void Xport::RemoveCart() XmlExit("No such cart",404); } if(!xport_user->deleteCarts()) { - XmlExit("Unauthorized",403); + XmlExit("Unauthorized",404); } // @@ -454,7 +454,7 @@ void Xport::AddCut() XmlExit("No such cart",404); } if(!xport_user->editAudio()) { - XmlExit("Forbidden",403); + XmlExit("Forbidden",404); } // @@ -620,7 +620,7 @@ void Xport::EditCut() XmlExit("No such cart",404); } if(!xport_user->editAudio()) { - XmlExit("Forbidden",403); + XmlExit("Forbidden",404); } // @@ -911,7 +911,7 @@ void Xport::RemoveCut() XmlExit("No such cart",404); } if(!xport_user->editAudio()) { - XmlExit("Forbidden",403); + XmlExit("Forbidden",404); } // diff --git a/web/rdxport/deleteaudio.cpp b/web/rdxport/deleteaudio.cpp index e0f2254a..febe4026 100644 --- a/web/rdxport/deleteaudio.cpp +++ b/web/rdxport/deleteaudio.cpp @@ -49,7 +49,7 @@ void Xport::DeleteAudio() // Process Request // if((!xport_user->deleteCarts())&&(!xport_user->adminConfig())) { - XmlExit("User not authorized",403); + XmlExit("User not authorized",404); } RDCut *cut=new RDCut(cartnum,cutnum); if(!cut->exists()) { diff --git a/web/rdxport/import.cpp b/web/rdxport/import.cpp index 94700824..c7768c1a 100644 --- a/web/rdxport/import.cpp +++ b/web/rdxport/import.cpp @@ -101,10 +101,10 @@ void Xport::Import() } } if(!xport_user->editAudio()) { - XmlExit("Forbidden",403); + XmlExit("Forbidden",404); } if(create&&(!xport_user->createCarts())) { - XmlExit("Forbidden",403); + XmlExit("Forbidden",404); } //