From cff45fdc83f8357a9e9fc3cbbbd522a76808f70a Mon Sep 17 00:00:00 2001 From: Patrick Linstruth Date: Thu, 4 Oct 2018 12:02:22 -0700 Subject: [PATCH 1/3] Add rda->log() to Xport::XmlExit --- web/rdxport/rdxport.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/web/rdxport/rdxport.cpp b/web/rdxport/rdxport.cpp index 68ffe418..402d5602 100644 --- a/web/rdxport/rdxport.cpp +++ b/web/rdxport/rdxport.cpp @@ -447,6 +447,8 @@ void Xport::XmlExit(const QString &str,int code,const QString &srcfile, if(xport_post!=NULL) { delete xport_post; } + rda->log(RDConfig::LogErr,QString().sprintf("%s '%s' %s",(const char *)str,(const char *)srcfile, + (srcline>0)?(const char *)QString().sprintf("line %d",srcline):"")); #ifdef RDXPORT_DEBUG if(srcline>0) { RDXMLResult(str+" \""+srcfile+"\" "+QString().sprintf("line %d",srcline), From 5cfb6441c606ea11a58af7b8063629e6158ce7f4 Mon Sep 17 00:00:00 2001 From: Patrick Linstruth Date: Thu, 4 Oct 2018 12:05:42 -0700 Subject: [PATCH 2/3] Updated ChangeLog --- ChangeLog | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ChangeLog b/ChangeLog index bf28d03f..26e77f2b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -17642,3 +17642,5 @@ 2018-09-20 Fred Gleason * Corrected an omission in the documentation of the 'Start Button' ['PB'] RML. +2018-10-04 Patrick Linstruth + * Added exit logging to rdxport.cgi. From 3e56afec0c4046184507bf54e5d84b35df395f97 Mon Sep 17 00:00:00 2001 From: Patrick Linstruth Date: Tue, 16 Oct 2018 09:47:32 -0700 Subject: [PATCH 3/3] Only log error if code is >= 400 --- web/rdxport/rdxport.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/web/rdxport/rdxport.cpp b/web/rdxport/rdxport.cpp index 402d5602..72215bb7 100644 --- a/web/rdxport/rdxport.cpp +++ b/web/rdxport/rdxport.cpp @@ -447,8 +447,10 @@ void Xport::XmlExit(const QString &str,int code,const QString &srcfile, if(xport_post!=NULL) { delete xport_post; } - rda->log(RDConfig::LogErr,QString().sprintf("%s '%s' %s",(const char *)str,(const char *)srcfile, - (srcline>0)?(const char *)QString().sprintf("line %d",srcline):"")); + if(code>=400) { + rda->log(RDConfig::LogErr,QString().sprintf("%s '%s' %s",(const char *)str,(const char *)srcfile, + (srcline>0)?(const char *)QString().sprintf("line %d",srcline):"")); + } #ifdef RDXPORT_DEBUG if(srcline>0) { RDXMLResult(str+" \""+srcfile+"\" "+QString().sprintf("line %d",srcline),