Autres/Rivendellaudio
1
0
Fork 0
mirror of https://github.com/ElvishArtisan/rivendell.git synced 2025-12-17 14:11:14 +01:00
Code Issues Projects Releases Wiki Activity

2021-06-01 Fred Gleason <fredg@paravelsystems.com>

Browse Source 
* Cleaned up compile warnings in 'lib/rdtextfile.cpp'.

Signed-off-by: Fred Gleason <fredg@paravelsystems.com>
This commit is contained in:
Fred Gleason
2021-06-01 12:50:27 -04:00
parent 4173eb3b95
commit 073d5e9caa
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ChangeLog
View File

@@ -21786,3 +21786,5 @@
* Cleaned up compile warnings in 'lib/rdreport.cpp'. * Cleaned up compile warnings in 'lib/rdreport.cpp'.
2021-06-01 Fred Gleason <fredg@paravelsystems.com> 2021-06-01 Fred Gleason <fredg@paravelsystems.com>
* Cleaned up compile warnings in 'lib/rdsvc.cpp'. * Cleaned up compile warnings in 'lib/rdsvc.cpp'.
2021-06-01 Fred Gleason <fredg@paravelsystems.com>
* Cleaned up compile warnings in 'lib/rdtextfile.cpp'.

13
lib/rdtextfile.cpp
View File

@@ -2,7 +2,7 @@
// //
// Spawn an external text file viewer. // Spawn an external text file viewer.
// //
// (C) Copyright 2002-2018 Fred Gleason <fredg@paravelsystems.com> // (C) Copyright 2002-2021 Fred Gleason <fredg@paravelsystems.com>
// //
// This program is free software; you can redistribute it and/or modify // This program is free software; you can redistribute it and/or modify
// it under the terms of the GNU General Public License version 2 as // it under the terms of the GNU General Public License version 2 as
@@ -49,7 +49,7 @@ bool RDTextFile(const QString &data,bool delete_on_exit)
"Too many arguments to report editor!"); "Too many arguments to report editor!");
return false; return false;
} }
strncpy(cmd,f0.at(0).toUtf8(),PATH_MAX); strncpy(cmd,f0.at(0).toUtf8(),PATH_MAX-1);
QStringList f1=f0.at(0).split("/"); QStringList f1=f0.at(0).split("/");
args[0]=(char *)malloc(f1.back().toUtf8().size()+1); args[0]=(char *)malloc(f1.back().toUtf8().size()+1);
strcpy(args[0],f1.back().toUtf8()); strcpy(args[0],f1.back().toUtf8());
@@ -63,7 +63,10 @@ bool RDTextFile(const QString &data,bool delete_on_exit)
QMessageBox::warning(NULL,"File Error","Unable to create temporary file"); QMessageBox::warning(NULL,"File Error","Unable to create temporary file");
return false; return false;
} }
write(fd,data.toUtf8(),data.toUtf8().length()); if(write(fd,data.toUtf8(),data.toUtf8().length())!=data.toUtf8().length()) {
rda->syslog(LOG_WARNING,"RDTextFile write lost data [%s]",
strerror(errno));
}
::close(fd); ::close(fd);
if(delete_on_exit) { if(delete_on_exit) {
rda->addTempFile(tmpfile); rda->addTempFile(tmpfile);
@@ -99,7 +102,7 @@ bool RDTextViewer(const QString &filename)
"Too many arguments to report editor!"); "Too many arguments to report editor!");
return false; return false;
} }
strncpy(cmd,f0.at(0).toUtf8(),PATH_MAX); strncpy(cmd,f0.at(0).toUtf8(),PATH_MAX-1);
QStringList f1=f0.at(0).split("/"); QStringList f1=f0.at(0).split("/");
args[0]=(char *)malloc(f1.back().toUtf8().size()+1); args[0]=(char *)malloc(f1.back().toUtf8().size()+1);
strcpy(args[0],f1.back().toUtf8()); strcpy(args[0],f1.back().toUtf8());
@@ -140,7 +143,7 @@ bool RDWebBrowser(const QString &url)
"Too many arguments to web browser!"); "Too many arguments to web browser!");
return false; return false;
} }
strncpy(cmd,f0.at(0).toUtf8(),PATH_MAX); strncpy(cmd,f0.at(0).toUtf8(),PATH_MAX-1);
QStringList f1=f0.at(0).split("/"); QStringList f1=f0.at(0).split("/");
args[0]=(char *)malloc(f1.back().toUtf8().size()+1); args[0]=(char *)malloc(f1.back().toUtf8().size()+1);
strcpy(args[0],f1.back().toUtf8()); strcpy(args[0],f1.back().toUtf8());