Autres/RaspAP
1
0
Fork 0
mirror of https://github.com/billz/raspap-webgui.git synced 2025-07-05 21:09:04 +02:00
Code Issues Releases Wiki Activity

Merge pull request #1872 from RaspAP/fix/plugin-installers-packages

Browse Source 
Fix installDependencies() to correctly handle packageList array
This commit is contained in:
Bill Zimmerman 2025-06-04 17:42:30 +02:00 committed by GitHub
commit f4adbc1725
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/RaspAP/Plugins/PluginInstaller.php
View File

@ -269,10 +269,16 @@ class PluginInstaller
*/ */
private function installDependencies(array $dependencies): void private function installDependencies(array $dependencies): void
{ {
$packages = array_keys($dependencies); if (empty($dependencies)) {
$packageList = implode(' ', $packages); return; // nothing to do
}
$cmd = sprintf('sudo %s packages %s', escapeshellarg($this->helperScriptPath), escapeshellarg($packageList)); $packageList = implode(' ', array_map('escapeshellarg', array_keys($dependencies)));
$cmd = sprintf(
'sudo %s packages %s',
escapeshellarg($this->helperScriptPath),
$packageList
);
$return = shell_exec($cmd); $return = shell_exec($cmd);
if (strpos(strtolower($return), 'ok') === false) { if (strpos(strtolower($return), 'ok') === false) {
throw new \Exception('Plugin helper failed to install depedencies.'); throw new \Exception('Plugin helper failed to install depedencies.');